Preserve input data types #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output heterogeneous data types
|
Tests failed on README.rst, line 187 for 2 reasons
|
|
The only failing check now is number 2. With permission, I would like to edit the test so that the output columns of |
dukebody
reviewed
May 5, 2018
There was a problem hiding this comment.
Thanks for your contribution! I was going to comment requesting changes in your PR, but I did them myself in https://github.com/scikit-learn-contrib/sklearn-pandas/pull/153/files. If everything looks good I'm gonna merge that one.
| @@ -504,3 +509,4 @@ Other contributors: | |||
| * Ritesh Agrawal (@ragrawal) | |||
| * Vitaley Zaretskey (@vzaretsk) | |||
| * Zac Stewart (@zacstewart) | |||
| * Timothy Sweetser (@hacktuarial) | |||
There was a problem hiding this comment.
Please preserve the alphabetic order. :)
|
Looks great! Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #138, when using
DataFrameMapperwithdefault=None, the current behavior is to create anp.arraywith the unselected columns. This has the undesired side effect of casting them to a common data type. This PR preserves the data types of unselected columns whendefault=None, input_df=True, output_df=True.