Skip to content

[WIP] Ignore some cov viz #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

EmmaRenauld
Copy link
Contributor

@EmmaRenauld EmmaRenauld commented Feb 3, 2025

Adding some comments to ignore coverage, or adding tests to improve coverage

Below are listed the poorly covered functions in viz:

  • scilpy.viz.backends.fury (COVERAGE: FROM TO )
    - creating_interactive_window: only used with option --show_rendering (or not --silent) in a few scripts. Can't be used in github. Ignoring.
    - snapshot_scene: à voir, used in plot_each_shell et plot_proj_shell, used in viz.legacy, used in some script. Should be covered with new script in pr 1150)
    - create_contours_actor: à voir, only used in viz.slice.create_contours_slicer.
    - create_odf_actors: à voir, only used in viz.slice.create_peaks_actor.
    - Others already good

  • scilpy.viz.backends.pil (COVERAGE: FROM TO )

    • draw_2d_array_at_position: already covered, but very poorly. à voir, only used in screenshot.compose_image.
    • Others already good
  • scilpy.viz.backends.vtk: (COVERAGE: FROM TO )

    • lut_from_colors: Only used in color.lut_from_matplotib_name.. See below. À voir: devrait être amélioré.
    • create_tube_with_radii: ajouté option dans test_bundle_diameter, voir si ça passe
    • contours_from_data: à voir, only used in slice.create_contour_slider
    • Others already good
  • scil.viz.color : (COVERAGE: FROM TO )
    - generate_n_colors: Used in plot_each_shell and plot_proj_shell. Can't be tested. WIP Also used in sclicer.create_binham_slicer, à voir.
    - get_lookup_table: Unsure about this. See issue [BUG] Bug in color management #1152. To be managed elsewhere.
    - lut_from_matplotlib_name: Tested through new test for scil_viz_tractogram_seeds_3d. I added an option to hide the window in debug mode. À voir: devrait être amélioré.
    - clip_and_normalize_data: beaucoup de ifs pas testés, à voir.
    - ambiant_occlusion: Added option in test for scil_tractogram_assign_custom_color.py. À voir: devrait être amélioré.
    - generate_local_coloring: Added option in test for scil_tractogram_assign_custom_color.py. À voir: devrait être amélioré.
    - others already good

  • scil.viz.gradients: (COVERAGE: FROM TO )
    - plot_each_shell: Only used in scil_viz_gradient_screenshot. Cannot be tested. Ignoring.
    - plot_proj_shell: Only used in scil_viz_gradient_screenshot and in scil_gradients_validate_sampling. Cannot be tested. Ignoring.
    - build_ms_from_shell_idx: WIP. Todo: Add an option debug in script scil_viz_gradient_screenshot to be able to run some parts.

  • scil.viz.plot Already good.

  • scil.viz.screenshot: (COVERAGE: FROM TO )
    - screenshot_contour: could be managed, but leads to error. Opened a new PR: (voir ma branche fix_overlays)
    - screenshot_peaks: No peaks in test data to be able to add option in scil_viz_volume_screenshot. Todo: add issue.
    - compose_mosaic: Added a test in test_viz_volume_screenshot_mosaic. À vérifier si mieux:

  • scil.viz.sclice (COVERAGE: FROM TO )
    - create_texture_slicer``: voir si on peut gérer plus de "ifs" - create_contours_slicer: only used in screenshot.screenshot_contour. See above. - create_peask_slicer: used in screenshot.screenshot_peaks(see higher) (À voir, et dans scil_viz_fodf. Vérifier si PR1150 règle ça) -create_odf_sclier: dans scil_viz_fodf. Vérifier si PR1150 règle ça) - create_bingham_slicer`: ?? pourquoi ça passe pas dedans dans scil_viz_bingham_fit? À voir

  • scil.viz.utils: (COVERAGE: FROM TO )
    - check_mosaic_layout: Will be ok if I manage to add a test for screenshot_mosaic.
    - compute_cell_topleft_pos: idem

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 31.14754% with 42 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (a5d76d9) to head (94f0929).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   59.10%   59.91%   +0.81%     
==========================================
  Files         651      651              
  Lines       30725    30668      -57     
  Branches     3464     3447      -17     
==========================================
+ Hits        18161    18376     +215     
+ Misses      11096    10807     -289     
- Partials     1468     1485      +17     
Components Coverage Δ
Scripts 57.82% <31.66%> (+0.37%) ⬆️
Library 63.10% <0.00%> (+1.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmmaRenauld EmmaRenauld force-pushed the ignore_some_cov_viz branch 3 times, most recently from 2ca97d7 to 2fc15cd Compare April 4, 2025 19:29
@EmmaRenauld EmmaRenauld force-pushed the ignore_some_cov_viz branch 6 times, most recently from f0ac082 to d5ca206 Compare May 1, 2025 18:42
@EmmaRenauld EmmaRenauld force-pushed the ignore_some_cov_viz branch from d5ca206 to 94f0929 Compare May 5, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant