[WIP] Ignore some cov viz #1137
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some comments to ignore coverage, or adding tests to improve coverage
Below are listed the poorly covered functions in viz:
scilpy.viz.backends.fury (COVERAGE: FROM TO )
-
creating_interactive_window
: only used with option--show_rendering
(or not--silent
) in a few scripts. Can't be used in github. Ignoring.-
snapshot_scene
: à voir, used inplot_each_shell
etplot_proj_shell
, used in viz.legacy, used in some script. Should be covered with new script in pr 1150)-
create_contours_actor
: à voir, only used inviz.slice.create_contours_slicer
.-
create_odf_actors
: à voir, only used inviz.slice.create_peaks_actor
.- Others already good
scilpy.viz.backends.pil (COVERAGE: FROM TO )
draw_2d_array_at_position
: already covered, but very poorly. à voir, only used inscreenshot.compose_image
.scilpy.viz.backends.vtk: (COVERAGE: FROM TO )
lut_from_colors
: Only used incolor.lut_from_matplotib_name.
. See below. À voir: devrait être amélioré.create_tube_with_radii
: ajouté option dans test_bundle_diameter, voir si ça passecontours_from_data
: à voir, only used inslice.create_contour_slider
scil.viz.color : (COVERAGE: FROM TO )
-
generate_n_colors
: Used inplot_each_shell
andplot_proj_shell
. Can't be tested. WIP Also used insclicer.create_binham_slicer
, à voir.-
get_lookup_table
: Unsure about this. See issue [BUG] Bug in color management #1152. To be managed elsewhere.-
lut_from_matplotlib_name
: Tested through new test forscil_viz_tractogram_seeds_3d
. I added an option to hide the window in debug mode. À voir: devrait être amélioré.-
clip_and_normalize_data
: beaucoup de ifs pas testés, à voir.-
ambiant_occlusion
: Added option in test forscil_tractogram_assign_custom_color.py
. À voir: devrait être amélioré.-
generate_local_coloring
: Added option in test forscil_tractogram_assign_custom_color.py
. À voir: devrait être amélioré.- others already good
scil.viz.gradients: (COVERAGE: FROM TO )
-
plot_each_shell
: Only used inscil_viz_gradient_screenshot
. Cannot be tested. Ignoring.-
plot_proj_shell
: Only used inscil_viz_gradient_screenshot
and inscil_gradients_validate_sampling
. Cannot be tested. Ignoring.-
build_ms_from_shell_idx
: WIP. Todo: Add an option debug in scriptscil_viz_gradient_screenshot
to be able to run some parts.scil.viz.plot Already good.
scil.viz.screenshot: (COVERAGE: FROM TO )
-
screenshot_contour
: could be managed, but leads to error. Opened a new PR: (voir ma branche fix_overlays)-
screenshot_peaks
: No peaks in test data to be able to add option inscil_viz_volume_screenshot
. Todo: add issue.-
compose_mosaic
: Added a test in test_viz_volume_screenshot_mosaic. À vérifier si mieux:scil.viz.sclice (COVERAGE: FROM TO )
-
create_texture_slicer``: voir si on peut gérer plus de "ifs" -
create_contours_slicer: only used in
screenshot.screenshot_contour. See above. -
create_peask_slicer: used in
screenshot.screenshot_peaks(see higher) (À voir, et dans scil_viz_fodf. Vérifier si PR1150 règle ça) -
create_odf_sclier: dans scil_viz_fodf. Vérifier si PR1150 règle ça) -
create_bingham_slicer`: ?? pourquoi ça passe pas dedans dans scil_viz_bingham_fit? À voirscil.viz.utils: (COVERAGE: FROM TO )
-
check_mosaic_layout
: Will be ok if I manage to add a test for screenshot_mosaic.-
compute_cell_topleft_pos
: idem