LICENSE: tweak license file so the GitHub API detects it correctly. #10247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses https://github.com/licensee/licensee. It's very sensitive. Now I've installed licensee locally and experimented until running this Ruby program prints out the desired result: ``` require "licensee" scipy = Licensee.project("../scipy") print scipy.license.name print "\n" print scipy.matched_file.filename print "\n\n" ``` Result: ``` BSD 3-Clause "New" or "Revised" License LICENSE.txt ``` Also note that licensee uses a cache based on the Git hash. So experimenting with it requires committing your change each time.
This was referenced Jun 2, 2019
|
Okay I'm going to merge this, so I can verify that it actually resolved the issue. Please feel free to review and comment still, in case I missed something we can keep iterating till both everyone is happy and the GitHub API gives the desired result. |
|
Before:
After:
|
|
Thanks Ralf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to gh-10235.
The GitHub API uses https://github.com/licensee/licensee. It's very sensitive. Now I've installed
licenseelocally and experimented until running this Ruby program prints out the desired result:Result:
Also note that licensee uses a cache based on the Git hash. So experimenting with it requires committing your change each time.
licenseehappy (see Not detecting MIT License when using multiple rows of authors. licensee/licensee#373). The official OSI license template does not deal with the issue of multiple copyright holders.