fix: refactor unquoted array assignments #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
_comp_split-3
branch
2 times, most recently
from
3e92e23 to
0ad4153
Compare
The current code performs the splitting twice: the output of a command is first split by IFS, second joined by \n while adding the prefix `-`, and then again split by IFS, which is redundant. We may directly split the output by `_comp_compgen_split` while adding the prefix using the `-P` option.
akinomyoga
force-pushed
the
_comp_split-3
branch
from
0ad4153 to
cae43e9
Compare
akinomyoga
changed the title
scop
approved these changes
Feb 1, 2024
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Feb 8, 2024
The current version fails to generate any command names for the first word after the command name "gdb". This is a regression introduced in scop#1086 and pointed out in the comment: scop@73c5292#r138406647 Co-authored-by: Grisha Levit <[email protected]>
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Feb 8, 2024
The current version fails to generate any command names for the first word after the command name "gdb". This is a regression introduced in scop#1086 and pointed out in the comment: scop@73c5292#r138406647 Co-authored-by: Grisha Levit <[email protected]>
scop
pushed a commit
that referenced
this pull request
Feb 8, 2024
The current version fails to generate any command names for the first word after the command name "gdb". This is a regression introduced in #1086 and pointed out in the comment: 73c5292#r138406647 Co-authored-by: Grisha Levit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #1084 and #1085.This is ready.