fix: refactor array assignments with manual cur filtering
#1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
_comp_split
branch
from
0a2019d to
509e642
Compare
akinomyoga
changed the title
cur filteringcur filtering
scop
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #1084 and #1085.This is ready.
The changes in this PR are related to the array assignments with the maunal
curfiltering.For example, some of the existing codes perform the filtering by
| grep "^$cur". However, this does not work when$curcontains special characters of the regular expressions. We try to replace such a code with the regular filtering by the_comp_compgen_split. (This may change the existing behavior when the user actually expects the filtering by the regular expressions.)Some of the codes seem to have a reason for the manual filtering. I keep the existing manual filtering for such a case, but we might need some discussions to switch to the filtering by
_comp_compgen.