feat(_comp_compgen): support -P prefix with adjusted cur
#1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
changed the title
-P prefix with adjusted cur-P prefix with adjusted cur
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
4d35ac5 to
912eef8
Compare
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
912eef8 to
ddba5bc
Compare
akinomyoga
force-pushed
the
_comp_compgen-P
branch
2 times, most recently
from
60ea27f to
00a2be5
Compare
akinomyoga
changed the title
-P prefix with adjusted cur-P prefix with adjusted cur
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
00a2be5 to
86a7ae2
Compare
scop
approved these changes
Aug 9, 2025
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
c5793b1 to
975712a
Compare
The Bash builtin `compgen -P prefix ... -- "$cur"` prepends the prefix AFTER filtering completions using `$cur`. However, we usually want to filter completions with "$cur" starting with the prefix. To properly handle such a situation, one first needs to check if the current content of "$cur" is compatible. Then, one needs to modify $cur to remove the prefix part, generate completions, and prepends the prefix to the generated completions. This pattern is used frequently in the codebase, so it is good to handle it within `_comp_compgen`. This patch implements the option `-P` of `_comp_compgen`. When a non-empty string is specified to the `-P` option, it performs the necessary operations: the check and adjustment of $cur, the proper filtering by the prefix string, and prepending of the prefix string. Co-authored-by: Ville Skyttä <[email protected]>
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
975712a to
c755c68
Compare
akinomyoga
commented
Aug 9, 2025
* refactor(dot,gprof,protoc,ssh,7z): use `_comp_compgen -P` for optargs
* refactor(_comp_compgen_tilde): use `_comp_compgen -P` for `~...`
* refactor(curl,strings): use `_comp_compgen -P` for `@...`
* refactor(tshark): use `_comp_compgen -P` for `-[oX]-...`
* refactor({,u}mount,kcov,lintian): use `_comp_compgen -P` for `*,*`
* refactor(upgradepkg): use `_comp_compgen -P` for `*%*`
* refactor(_mount{,.linux}): use `_comp_compgen -P` for `//host/...`
* refactor(xgamma): use `_comp_compgen -P` for `-display:*.*`
akinomyoga
force-pushed
the
_comp_compgen-P
branch
from
c755c68 to
ec2f2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message.