Skip to content

doc improvements #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

doc improvements #1444

merged 2 commits into from
Oct 8, 2025

Conversation

Rudxain
Copy link
Contributor

@Rudxain Rudxain commented Sep 30, 2025 •
edited
Loading

  • change markdown code-block lang-tags from shell to bash (only where appropriate)
  • check if completions are already sourced in example .bashrc (in README)

fixes #1443

akinomyoga
akinomyoga reviewed Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, basically.

akinomyoga
akinomyoga reviewed Oct 4, 2025
View reviewed changes
@Rudxain Rudxain force-pushed the doc branch 3 times, most recently from c68538a to 31a148b Compare October 6, 2025 00:54
akinomyoga
akinomyoga reviewed Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the below, LGTM. Please squash the style change into the last commit.

akinomyoga
akinomyoga approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@akinomyoga akinomyoga merged commit acc4453 into scop:main Oct 8, 2025
6 of 7 checks passed
@Rudxain Rudxain deleted the doc branch October 9, 2025 01:57
@Rudxain Rudxain mentioned this pull request Oct 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

@yedayak yedayak yedayak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

how to avoid double-sourcing?

3 participants

@Rudxain @akinomyoga @yedayak