-
Notifications
You must be signed in to change notification settings - Fork 391
curl: fix option listing in newer versions #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The test failure seems unrelated, is there something else I should do here? |
Rebasing should fix the test failure. With regards to what to do here, I'd like to see a test suite addition for this. Basically one for which we'd check that an option that is only output with Additionally, we've adopted conventional commits comment message conventions recently, and starting from next version it's important we follow that, because it has direct effect on change log and bash-completion version generation. So rewording while rebasing suggested, let's say |
Hi! Any update on this PR? |
I need this change before performing the interface change of |
cd54397
to
2edaa32
Compare
_parse_help only takes a single parameter (which is then splits) for the options that it invokes the tool with.
2edaa32
to
e88a216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, added the requested test case, I'm good with merging this if/when it passes CI.
Thank you for adding the test! |
_parse_help
only takes a single parameter (which is then splits) for the options that it invokes the tool with, socurl
was being invoked with just--help
, not with--help all
.