fix(_known_hosts_real): remove empty hostnames #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
changed the title
Fix the problem mentioned in Ref [1]. This is a regression caused by commit 08dd2cd [2]. When there is an entry "Host *" in ssh_config, an empty hostname is generated. We exclude the empty completions using the compgen option "-X". [1] scop#720 (comment) [2] \ scop@08dd2cd#diff-a4757074ff650000804fd3eaabe9b0a9e02e33040ca5b8afd4c0275fc5f3e136R1886
akinomyoga
force-pushed
the
fix-empty-hostname
branch
from
4150d21 to
dd2dfba
Compare
|
Nice catch! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem mentioned in #720 (comment). This is a regression caused by
08dd2cdb - bash_completion:1886. When there is an entryHost *inssh_config, an empty hostname is generated. We exclude the empty completions by-X.