fix: add misc fixes before _comp_compgen_split
#985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one element is specified to printf, so it just appends a newline. However, the newline is anyway removed by the word splitting performed by -W. We can safely remove the modifications by printf '%s\n'. Before commit 1d3add4, the argument specified to `printf` was not quoted so that each word splitted by IFS is printed to an independent line. However, as IFS is $'\n' in this context, words are obtained by splitting the result with newlines, so outputting them by printf '%s\n' does not have any effects. References: scop@1d3add4#diff-efd1d1be37bc3e0c0b77e1a2d9ef05a7d9d7a09262b710adca23db163b18f387
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before applying
_comp_compgen_splitmentioned in #958 (comment), I would like to add the following fixes that are overlapping with it.