Draft: Out-of-box Experience

[roobscoob]

Looking for feedback on the OOBE. This PR depends on #39

This PR makes the DISCORD_TOKEN env argument obsolete. The environment variable will still be respected if available, and skip the OOBE.

[circularsprojects]

this looks really good so far!!!

[Bloeckchengrafik]

Looks great so far! Just a heads-up:
GPUI provides a way to store credentials in the platform keychain, which is more secure than simple file storage in many cases.

See https://github.com/zed-industries/zed/blob/eb2c0b33dff361a268b0276f8ec8bb38811d2c5e/crates/gpui/src/app.rs#L639-L652 for details

It might be worth opening an issue for this once the PR is merged, but I think implementing it now would be a better way.

What do you think?

[roobscoob]

Not in favor of using GPUI's credential API because it's so baked around the (url, username, password) tuple. We could hypothetically get around this by doing something like ("discord://token", "roobscoob", <censored>) but then I would say that it's lack of supporting multiple (username, password) pairs per url will bite us.

[jacksongoode]

36/crates/gpui/src/platform/mac/metal_renderer.rs
  cargo:rerun-if-changed=./src/platform/mac/shaders.metal

  --- stderr
  metal shader compilation failed:
  xcrun: error: unable to find utility "metal", not a developer tool or in PATH

warning: build failed, waiting for other jobs to finish...

I don't have Xcode installed but running into this build issue on macOS.

[DovidP]

You need xcode installed. Also this is a gpui error, not scope.

[jacksongoode]

Got it built, it seems that an invalid token will not fall back to login again? Is this PR accepting commits?

[circularsprojects]

iirc we can just query "users/@me" or something similar (which serenity already has a method for)
if it's invalid we get an error code and if it's valid we get username and stuff which we can use for a welcome screen like "welcome circular!"