Skip to content

Refactor #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Refactor #44

merged 3 commits into from
Dec 1, 2024

Conversation

roobscoob
Copy link
Contributor

A large refactor of discord, chat, and ui, in an attempt to move to serenity structures, and to move rendering onto the responsibility of chat backends.

Copy link
Contributor

@Bloeckchengrafik Bloeckchengrafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just one small thing: If a PR is marked as Draft, it seems to me like it is not done, so not ready to review. Don't take this personally, just my two cents

@roobscoob roobscoob marked this pull request as ready for review November 30, 2024 21:21
@roobscoob roobscoob requested review from bvvst and alii November 30, 2024 21:21
Copy link
Collaborator

@bvvst bvvst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge

@bvvst bvvst merged commit 931ca3f into main Dec 1, 2024
2 checks passed
@bvvst bvvst deleted the refactor branch December 1, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants