Skip to content

Ensure aggregate works even when plugin is disabled for modules. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ckipp01 opened this issue Oct 6, 2021 · 0 comments · Fixed by #377
Closed

Ensure aggregate works even when plugin is disabled for modules. #376

ckipp01 opened this issue Oct 6, 2021 · 0 comments · Fixed by #377
Labels
bug

Comments

@ckipp01
Copy link
Member

ckipp01 commented Oct 6, 2021

See typelevel/skunk#549 (comment) for context.
@ckipp01 ckipp01 added the bug label Oct 6, 2021
@ckipp01 ckipp01 mentioned this issue Oct 11, 2021
Merged
ckipp01 added a commit that referenced this issue Oct 11, 2021
@ckipp01 @scala-steward
Sync V2 (#378)
3db267c 
* Update scalafmt-core to 3.0.6

* Ensure reporting and aggregation still works when disabling modules.

In the past reporting and aggregation would fail when you tried to
disable Scoverage for a specific module. This now will only take into
account the modules that have the keys defined rather than defaulting to
all of them.

Closes #376

Co-authored-by: Scala Steward <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure reporting and aggregation still works when disabling modules.
1 participant
@ckipp01