Numbers in XML report are formatted based on Locale

[jketterl]

We are currently setting up scoverage on a handful of our play framework / activator based apps, and we noticed that the coverage display in the jenkins plugin did not work as expected (it kept showing 0% coverage, even though values in the html report were higher).

upon further inspection, we found that the jenkins plugin expects the values "statement-rate" and "branch-rate" in the coverage report XML to be parseable by Double.parseDouble(), e.g. "12.34", while the reports generated by our build contained numbers that are formatted according to our system locale setting ("de_DE.UTF-8"), e.g. "12,34" (notice the comma).

This might be debatable, but in my opinion an XML file should be portable between systems of different locales, and as such the locale should not have an influence on its contents. Checking the code this does not appear to be intentional to me either.

[sksamuel]

I wonder if the XML standard specifies that numbers should be formatted in the UK / USA style.

It's easily changed.

[jketterl]

I haven't checked any standards so far (and I'm in doubt that XML is that specific, considering that values usually are just strings from an xml point of view) but it seems logical to me from a portability point of view.

For me this might as well be fixed in the jenkins plugin (by parsing the numbers in a locale-dependent way) since everything runs on the same system, but this might not work in every case, that's why i filed the report here.

[pachenbach]

According to the datatypes definition of the XML Schema, the numbers have to be formatted with a dot as a delimiter: http://www.w3.org/TR/xmlschema-2/#decimal-lexical-representation

[lustefaniak]

Release 1.2.0 contains fixes for that problem, can you please check if it works correctly for you?

[jketterl]

I just updated our projects to sbt-scoverage 1.5.0, which depends on scalac-scoverage-plugin 1.3.0 and the problem is gone. thank you very much :)