Skip to content

Add support for Scala.js #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ssidorenko
Copy link
Contributor

This PR allows the runtime to be compiled for Scala.js, allowing scoverage to work with Scala.js projects.

Use this example application to see it in action.

def readFileSync(path: String, options:js.Dynamic): String = js.native
def rmdirSync(path: String): Unit = js.native
def unlinkSync(path: String): Unit = js.native
def writeSync(fd: Int, csq: CharSequence): Unit = js.native
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csq: String

CharSequence doesn't make sense to JavaScript. Only String does.

@sjrd
Copy link

sjrd commented May 6, 2015

That's all I have on the Scala.js side of things.

@ssidorenko ssidorenko force-pushed the scalajs branch 3 times, most recently from b93db05 to 304a301 Compare June 4, 2015 15:35
@sjrd
Copy link

sjrd commented Jun 4, 2015

Note that, as of yesterday, there is a snapshot of Scalatest that supports Scala.js. To minimize changes, it might be a good idea to use Scalatest instead of uTest.

@ssidorenko
Copy link
Contributor Author

For some reason, all tests pass on my computer but they don't on the travis server, any idea where that could come from ?

@sksamuel
Copy link
Member

Travis breaks all the time in my experience. I'll check out this PR shortly, sorry for the big delay.

@ngbinh
Copy link

ngbinh commented Jul 24, 2015

any update on this? Thanks

@ghost ghost mentioned this pull request Aug 1, 2015
@holograph
Copy link

Pinging @sksamuel...

@naderghanbari
Copy link

Any updates on this?

@japgolly
Copy link

What's the status of this? If there is only a small amount of work remaining, or the remaining work is trivial, I might be able to pick it up and get it over the line. My work project could really benefit from this right now.

@sksamuel
Copy link
Member

I've never used scala.js so don't know what is outstanding.

@lustefaniak
Copy link
Contributor

Please take a look at #158, there are cleaned up changes to scalac-scoverage-plugin, required changes to sbt-scoverage are here: scoverage/sbt-scoverage#166 and tests that it works here: scoverage/sbt-scoverage#167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants