-
Notifications
You must be signed in to change notification settings - Fork 127
Add support for Scala.js #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def readFileSync(path: String, options:js.Dynamic): String = js.native | ||
def rmdirSync(path: String): Unit = js.native | ||
def unlinkSync(path: String): Unit = js.native | ||
def writeSync(fd: Int, csq: CharSequence): Unit = js.native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
csq: String
CharSequence
doesn't make sense to JavaScript. Only String
does.
That's all I have on the Scala.js side of things. |
b93db05
to
304a301
Compare
Note that, as of yesterday, there is a snapshot of Scalatest that supports Scala.js. To minimize changes, it might be a good idea to use Scalatest instead of uTest. |
For some reason, all tests pass on my computer but they don't on the travis server, any idea where that could come from ? |
Travis breaks all the time in my experience. I'll check out this PR shortly, sorry for the big delay. |
any update on this? Thanks |
Pinging @sksamuel... |
Any updates on this? |
What's the status of this? If there is only a small amount of work remaining, or the remaining work is trivial, I might be able to pick it up and get it over the line. My work project could really benefit from this right now. |
I've never used scala.js so don't know what is outstanding. |
Please take a look at #158, there are cleaned up changes to scalac-scoverage-plugin, required changes to sbt-scoverage are here: scoverage/sbt-scoverage#166 and tests that it works here: scoverage/sbt-scoverage#167 |
This PR allows the runtime to be compiled for Scala.js, allowing scoverage to work with Scala.js projects.
Use this example application to see it in action.