-
Notifications
You must be signed in to change notification settings - Fork 127
fix resources url in generated HTML docs #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The only issue is for people for whom cannot access outside urls. For instance at my bank we are locked down (although those might be open). |
I know it. but there are other problems. I have CircleCI generate HTML coverage reports. |
using protocol relative urls for resources are recommended. cf. https://support.google.com/webmasters/answer/6073543?hl=en |
It doesn't work when the page is opened from local filesystem ( |
Certainly..., I will fix it. |
oh, i have missed. |
+1 I would love to see this merged and get the sbt-scoverage plugin updated to include it! I know circle CI was mentioned here, but more enterprises now are starting to run their internal build tools on https now in addition to the cloud based ones. The Scoverage report looks quite awful as the browser won't load any of the resources. |
fix resources url in generated HTML docs
HTML documents generated in
ScoverageHtmlWriter
require CSS and JavaScript resources.But urls of the resources are not unified into HTTP or HTTPS.
I have fixed them by omitting protocol in the absolute url, and they are available both via HTTP and HTTPS.