Fix splitting source into lines on Windows OS when source file contains Linux line ending characters ("\n"). #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns Linux line ending characters ("\n").
In this case code grid report doesn't split source file into lines at all because it tries to split on Windows line ending sequence ("\r\n") and there is no such sequence in source file.
'\r' characters should be treated as every other character (as it's treated now on Linux OS when source file contains Windows line ending sequences). Only '\n' characters should be used to split source into lines. It will work even if source file has mixed line endings.
|
Currently code grid report looks like this (there is only line no. 1):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case code grid report doesn't split source file into lines at all because it tries to split on Windows line ending sequence ("\r\n") and there is no such sequence in source file.
'\r' characters should be treated as every other character (as it's treated now on Linux OS when source file contains Windows line ending sequences). Only '\n' characters should be used to split source into lines. It will work even if source file has mixed line endings.