Improve instrumentation of "try" statement without "finally" section #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't instrumented before when it was missing, but `Could not instrument [EmptyTree$/null]. No pos.` warning was emitted. Now `instrument` method will be called only if `finnaly` section is present.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument
finallysection only if it is present.It wasn't instrumented before when it was missing, but
Could not instrument [EmptyTree$/null]. No pos.warning was emitted. Nowinstrumentmethod will be called only iffinnalysection is present.This fixes many (if not all) remaining
Could not instrument [EmptyTree$/null]. No pos.warnings reported in #5