Skip to content

include local copy of pure-min.css #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2020
Merged

include local copy of pure-min.css #236

merged 3 commits into from
Sep 5, 2020

Conversation

thepler
Copy link
Contributor

@thepler thepler commented Oct 17, 2018

addresses: #173

@xiaodongw
Copy link

I'm seeing the same problem in Jenkins, this is a valid fix, can we merge it?

@gslowikowski
Copy link
Member

Actually I don't know.

There is licensing info in the original file:

/*!
Pure v0.3.0
Copyright 2013 Yahoo! Inc. All rights reserved.
Licensed under the BSD License.
https://github.com/yui/pure/blob/master/LICENSE.md
*/
/*!
normalize.css v1.1.2 | MIT License | git.io/normalize
Copyright (c) Nicolas Gallagher and Jonathan Neal
*/
/*! normalize.css v1.1.2 | MIT License | git.io/normalize */

Scoverage plugin uses Apache License Version 2.0.

I don't know if that css file can be added here.

@thepler
Copy link
Contributor Author

thepler commented Feb 4, 2019

I'm seeing the same problem in Jenkins, this is a valid fix, can we merge it?

I also hit this problem when dealing with Jenkins. However, at this point I believe this may be necessary, but perhaps not sufficient, as a full fix for the underlying problem.

@pbassiner
Copy link

Is there any chance this could be merged and included in the next release so we can collect the feedback of all affected users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants