Don't do a fully binary cross of runtime, only the compiler plugin #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking back at ac3db32, I'm not actually 100% sure this was accurate. While we do need to do a fully binary publish of the actual compiler plugin, doing a full cross of the runtime artifact causes some issues. Mainly I just don't believe it's needed, but also then when publishing for other platforms, there is odd behavior where you no longer get the sjs prefix that you'd want in your artifacts published for JS. This change updates a few of the sbt dependencies, moves to the unified slash syntax, and only applies the full cross settings to the actual compiler plugin, not the runtime artifact.
|
Actually looking at the test failures it does seem that the runtime also need to be published for everything 🤔. That's sort of a bummer. I guess then the thing I'm stuck on is that I can't figure out how to cross that fully since once you set the |
|
Closing in favor of #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking back atac3db32,
I'm not actually 100% sure this was accurate. While we do need to do a
fully binary publish of the actual compiler plugin, doing a full cross
of the runtime artifact causes some issues. Mainly I just don't believe
it's needed, but also then when publishing for other platforms, there is
odd behavior where you no longer get the sjs prefix that you'd want in
your artifacts published for JS. This change updates a few of the sbt
dependencies, moves to the unified slash syntax, and only applies the
full cross settings to the actual compiler plugin, not the runtime
artifact.
EDIT: See below
@blast-hardcheese Are you able to take a look at this since you originally made these changes.
This should fix the issue I mentioned having in #305