Report test results more visibly #313
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test report for scratch-svg-renderer 1 files 60 suites 0s ⏱️ Results for commit 44cb5f9. ♻️ This comment has been updated with latest results. |
Test report for scratch-vm 1 files 770 suites 1m 6s ⏱️ Results for commit 44cb5f9. ♻️ This comment has been updated with latest results. |
Test report for scratch-render 1 files 55 suites 2s ⏱️ Results for commit 44cb5f9. ♻️ This comment has been updated with latest results. |
Test report for scratch-gui 2 files 61 suites 8m 52s ⏱️ Results for commit 44cb5f9. ♻️ This comment has been updated with latest results. |
cwillisf
force-pushed
the
make-test-failures-visible
branch
from
f45a732 to
44cb5f9
Compare
KManolov3
approved these changes
Sep 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Use
EnricoMi/publish-unit-test-result-actionto report the details of test results more visibly, including GHA annotations.Reason for Changes
Contributors who aren't part of the scratchfoundation GitHub organization can see when a GHA workflow job fails, but they can't see the full logs. Seeing that a job failed doesn't help much if you can't tell why it failed, especially considering that we sometimes have flaky tests, chromedriver trouble, or other test failures that aren't the fault of a PR. This change allows folks to see the specific reason for a test failure and determine whether or not it's related to their changes.
Test Coverage
Here's a run with some intentional test failures: https://github.com/scratchfoundation/scratch-editor/actions/runs/17619379994
This PR also includes some comments generated by the test results reporter. The reporter updated the comments to reflect that the tests have been "fixed" (the intentional failures have been removed), but the earlier version is available through GitHub's comment history feature.