Fix dragging monitors on small stage #314
Open
+42
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
(most of these are duplicates of each other)
There is a PR that solves this issue in scratch-gui but I think this way it can be solved with much less changes (out of the 42 added rows 22 is just changing white space for eslint, only the other 20 rows are actual changes)
Proposed Changes
Describe what this Pull Request does
<Box>
that used to do the CSS transformscale
property on the<Draggable>
scale
is a fractiongrid
property on the<Draggable>
handleDragEnd
event handlerReason for Changes
Explain why these changes should be made
<Draggable>
doesn't round the coordinates for the event handlerTest Coverage
Please show how you have added tests to cover your changes
I've run
npm test
and it accepted it (I think) (it didn't say "error" like when it didn't like the identation)I've tried it out in these browsers and it seems to work
I've temporarily added this to
handleDragEnd
for testing and it didn't cause any popups: