Fix typed array exception in Edge #132
Merged
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
fix exception "Invalid offset/length when creating typed array" in ms edge browser
Proposed Changes
just convert the float to integer use Math.floor
new Uint8Array(Math.floor(bounds.width * bounds.height * 4))
Reason for Changes
new Uint8Array(10.1)
if the parameter of the Uint8Array constructor is not integer, chrome browser ignor the 0.1, but the edge browser throw an exception "Invalid offset/length when creating typed array".
just run the playground of scratch-vm or the scratch-gui in the edge browser, and use f12 develop tools to change the size of the stage, then you will got the exception