Ignore sprite visibility when testing for touching color #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@towerofnix thanks for the demo projects. I verified with the falling cat project and also added a commit to fix the
|
cwillisf
approved these changes
Dec 8, 2017
There was a problem hiding this comment.
Nice catch! Thanks @towerofnix and @paulkaplan!
There's one comment that could use an update, but other than that this looks great!
src/RenderWebGL.js
Outdated
| @@ -1115,7 +1119,7 @@ class RenderWebGL extends EventEmitter { | |||
| /** @todo check if drawable is inside the viewport before anything else */ | |||
|
|
|||
| // Hidden drawables (e.g., by a "hide" block) are not drawn unless stamping | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Fixes #212
Proposed Changes
Describe what this Pull Request does
Make the draw step of the touching color test ignore sprite visibility. Use the same flag as
isStampingbut rename for more general use case.Also return
falsewhen there are no candidate sprites to test nearby, instead of returning undefined.Reason for Changes
Explain why these changes should be made
To bring the touching color behavior in line with scratch 2.
Test Coverage
Please show how you have added tests to cover your changes
Tested the demo project I made in the linked issue. Now it matches scratch 2