Scratch 2 changes color in HSV space. #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scratch 2 color and brightness effects in HSV color space.
mzgoddard
force-pushed
the
hsv-brightness
branch
from
0635554 to
f87eb00
Compare
|
/cc @kchadha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Part of scratchfoundation/scratch-vm#1283
Proposed Changes
Change fragment shader color space handling from HSL to HSV.
Reason for Changes
Scratch 2 changes color in HSV space.
Test Coverage
https://scratch.mit.edut/projects/242576633/
http://localhost:8601/#242576633