ImageData WebGL Textures #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mzgoddard ! |
Given ImageData we can skip drawing the input and getting image data. This can help if update's color can also use the ImageData directly.
mzgoddard
force-pushed
the
image-data-texture
branch
from
707332e to
eaeb183
Compare
cwillisf
reviewed
Mar 1, 2019
When possible pass ImageData to texture creation and updating to help remove chance of references that keep canvas and underlying data from being garbage collected.
mzgoddard
force-pushed
the
image-data-texture
branch
from
eaeb183 to
e31934f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Load faster and use less memory.
Proposed Changes
Reason for Changes
Getting the ImageData in setBitmap and setSVG lets us skip an extra draw operation to Silhouette's update canvas. It likely also skips a step browsers perform to do a operation similar to getImageData and instead use ImageData directly. This provides a significant reduction in the time it takes to turn asset data in Storage into a Skin.
Benchmark Data
Pending ...