Replace Silhouette._data with Silhouette._colorData #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgoddard
force-pushed
the
drop-silhouette-alpha-buffer
branch
from
a2945df to
ca922d2
Compare
_colorData holds the same (and more) data that _data holds. Dropping the _data array saves a lot of memory for a tiny performance degradation in regards to touching object.
mzgoddard
force-pushed
the
drop-silhouette-alpha-buffer
branch
from
ca922d2 to
e022222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Use less memory.
Proposed Changes
Replace Silhouette._data with Silhouette._colorData
Reason for Changes
_colorData holds the same (and more) data that _data holds. Dropping the _data array saves a lot of memory for a tiny performance degradation in regards to touching object.
I'm not sure we can measure the performance difference.
Benchmark Data
Pending ...