Tweak scalingVector to make dots appear to be more circular #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @seotts |
|
/cc @kchadha |
ktbee
changed the title
cwillisf
approved these changes
Apr 30, 2019
|
@cwillisf good point! These numbers were just a matter of picking what looked good/better, but I can add a comment explaining that since they do seem mysteriously specific. |
ktbee
force-pushed
the
more-circular-pen-dots
branch
from
b104b5a to
2042018
Compare
ktbee
force-pushed
the
more-circular-pen-dots
branch
from
2042018 to
9fc82a8
Compare
|
@cwillisf I added a comment to explain the rationale behind the different alias numbers. Let me know if it clarifies things enough! |
|
Sorry for the delay! If there were some math-based reason for the numbers then I would ask for that math to be explained, but since it's just eyeballed I think your comments are fine. Thanks! |
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
scratchfoundation/scratch-gui#4313
Proposed Changes
Tweak the alias ratios for the scalingVector
Reason for Changes
These changes to the scalingVector helps make circles a little wider. Currently they are a little taller than they are wide, which makes them look like vertical ovals. This change to make the Y scalingVector smaller helps balances the circle dimensions.
Screenshots
I took some screen shots to try to capture how these changes affect circles. I recommend clicking the screenshot to fullscreen it and see more detail.