Revert "Revert "Put Skin Alter Push Back In"" #509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah. So each draw calls updateBitmapSkin or updateSVGSkin. When the call is on a skin of the other type it'll create a new skin of the right type, but I overlooked binding the event listener here. So the first draw in the new type, will update the drawable matrix because the drawable's skin changes, reseting the matrix. When the second draw happens, the drawable draws the right skin, but the matrix isn't updated as it doesn't get a message from the skin changing, making it draw in the small first matrix. |
|
So, um. Revert "Revert "Revert "Revert "Revert "Revert "Skin alter push"""""". 📦 I'll stop now [: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #508
Changes from #470 were taken out again because of a bug where making costume edits in the paint editor makes the costume change size on the stage:
cc/ @mzgoddard, @cwillisf