Update EffectTransform.transformColor to match GPU "color" + "brightness" effects #542
+103
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
effect-transform-parity
branch
from
794cd26 to
8b643b6
Compare
adroitwhiz
force-pushed
the
effect-transform-parity
branch
from
8b643b6 to
d513b83
Compare
adroitwhiz
force-pushed
the
effect-transform-parity
branch
from
d513b83 to
21ee6ba
Compare
adroitwhiz
changed the title
cwillisf
approved these changes
Jul 14, 2020
Co-authored-by: Chris Willis-Ford <[email protected]>
cwillisf
approved these changes
Aug 17, 2020
this makes it safer to call hsvToRgb without worrying about h=1, which previously caused incorrect results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #578
Proposed Changes
This PR changes
EffectTransform.transformColorto match what thesprite.fragshader does with regards to the brightness and color effects.In particular, it implements the "color" effect as a hue shift in HSV space, and the "brightness" effect as an addition in RGB space.
Reason for Changes
EffectTransformis used in the CPU "touching color" pipeline, and so it should give the exact same results as the GPU.Test Coverage
CPU/GPU parity tests are blocked on #537