Run integration tests on both the CPU and GPU (again) #598
+57
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
cpu-gpu-integration-tests
branch
2 times, most recently
from
979c1db to
4d14729
Compare
fsih
reviewed
May 11, 2020
adroitwhiz
force-pushed
the
cpu-gpu-integration-tests
branch
2 times, most recently
from
516bc84 to
59515c1
Compare
There are some compatibility concerns to be worked out before the corresponding bug can be fixed.
Previously, the `color-touching-tests.sb2` test "touches a color that doesn't actually exist right now" would use a sprite with ghost 50, blended against another sprite, to create the color that "doesn't actually exist" when the query sprite is skipped. Unfortunately the blend result was near a bit-boundary and, depending on the specific hardware used, that test could fail on the GPU. When the renderer uses the CPU path this test works fine, though, so the existing problem went unnoticed. To fix the problem I changed the project to use ghost 30 instead, which results in a color that is less near a bit boundary and is therefore less likely to fail on specific hardware. As an example of what was happening: the `touching color` block was checking for `RGB(127,101,216)` with a mask of `RGB(0xF8,0xF8,0xF0)`. On the CPU it would find `RGB(120,99,215)`, which is in range, but on some GPUs the closest color it could find was `RGB(119,98,215)` which mismatches on all four of the least significant bits -- one of which is enabled in the mask.
adroitwhiz
force-pushed
the
cpu-gpu-integration-tests
branch
from
59515c1 to
298200f
Compare
cwillisf
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #597
Resolves
Resolves #587
Proposed Changes
This PR adapts the changes in f9428ee to the new Playwright-based testing code.
Reason for Changes
This should increase test coverage and hopefully prevent future bugs that only occur on either the CPU or GPU and as such were not caught by the previous testing behavior.
Test Coverage
Tests currently fail, which is good because they're catching existing bugs. #576 will need to be merged before tests will pass again. For now, I've disabled the "doesn't touch text bubble" test because there are potential compatibility concerns I want to work out before fixing that (#577).