Skip to content

Playwright: the re-wright #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 11, 2020
Merged

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented May 11, 2020

Resolves

Resolves #564
Resolves #601

Proposed Changes

This is #597, but with some extra stuff to fix Travis:

  • Cache ~/.cache/ms-playwright in Travis so that the downloaded Chromium binary always exists
  • Exit the tests with process exit code 1 if a promise throws an error, so that builds do not pass if an error occurs when testing

Reason for Changes

See #597

Test Coverage

Yes

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the extra attention to error handling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests aren't set up correctly on CI Chromeless, used for integration tests, is deprecated
2 participants