Skip to content

Conversation

adroitwhiz
Copy link
Contributor

Depends on #555

Resolves

Resolves #545
Resolves #558

Proposed Changes

This PR changes _drawThese to accept optional framebufferWidth and framebufferHeight parameters, and default to the "native size" (480x360) if they're not given.

These dimensions are used to calculate drawables' "framebuffer-space" scales.

Reason for Changes

See #545.

@adroitwhiz adroitwhiz force-pushed the stamp-pen-layer-scale branch from 955509c to 217498b Compare June 3, 2020 20:16
@adroitwhiz adroitwhiz force-pushed the stamp-pen-layer-scale branch from 217498b to 26fe38c Compare November 9, 2020 23:31
@adroitwhiz
Copy link
Contributor Author

@cwillisf This resolves #558, which is priority 2, so I want to make sure this hasn't fallen off your radar (given it has no "needs review" tag and is sandwiched in between several Dependabot PRs).

@cwillisf
Copy link
Contributor

It looks to me like the extractDrawable methods should provide buffer dimensions when calling _drawThese since it might use the query buffer OR a new, potentially very large buffer.

@adroitwhiz
Copy link
Contributor Author

Good catch! I've done this for extractDrawableScreenSpace--does anything still use extractDrawable other than the playground? I can't see anything in any public repos. Regardless, it looks like extractDrawable does everything at the "Scratch-space" resolution anyway, so I think it should be left as is.

Copy link
Contributor

@fsih fsih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

We're planning to not deploy changes during December, due to the annual hour of code and holidays, so will be holding off on merging until January

@fsih fsih merged commit 01a4057 into scratchfoundation:develop Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stamp Quality Differs Depending on Stage Size drawableScale should consider current render target
3 participants