Don't multiply SVG size by device pixel ratio #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwillisf I ran a quick benchmark on this animation, and this change reduces RAM usage on pixel-ratio 2 devices (e.g. mobile devices) by around 40%: |
|
@thisandagain Any update on this? This would save a substantial amount of RAM on mobile devices (see above), especially once scratchfoundation/scratch-render#431 is merged. |
fsih
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
This looks great, thanks!
It looks like with this change, calls to _draw caused by setSVG in scratch-render no longer take into account device pixel density. However, I think that those calls are unnecessary, since they are immediately overwritten by a call to _draw started by _step in vm. So I've opened scratchfoundation/scratch-render#518
fsih
added a commit
to scratchfoundation/scratch-paint
that referenced
this pull request
Nov 1, 2019
….0-prerelease.20191031221353 Update scratch-svg-renderer to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84
fsih
added a commit
to scratchfoundation/scratch-render
that referenced
this pull request
Nov 1, 2019
….0-prerelease.20191031221353 Update scratch-svg-renderer to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84
fsih
added a commit
to scratchfoundation/scratch-gui
that referenced
this pull request
Nov 1, 2019
…2.0-prerelease.20191031221353 Update scratch-svg-renderer to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84
fsih
added a commit
to scratchfoundation/scratch-gui
that referenced
this pull request
Nov 2, 2019
…release.20191101193358 Update scratch-paint to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84 via paint
fsih
added a commit
to scratchfoundation/scratch-gui
that referenced
this pull request
Nov 2, 2019
…erelease.20191101193213 Update scratch-render to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84 via render
paulkaplan
pushed a commit
to paulkaplan/scratch-labs-test
that referenced
this pull request
Sep 18, 2020
….0-prerelease.20191031221353 Update scratch-svg-renderer to the latest version 🚀 brings in scratchfoundation/scratch-svg-renderer#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This changes SvgRenderer so that, when told to draw an SVG at a certain scale, it doesn't multiply the scale by the device pixel ratio.
Reason for Changes
The WebGLRenderer already handles all the device pixel ratio stuff [EDIT: here], and passes the SvgRenderer the proper scale for the device. By enlarging the SVGs here as well, the SvgRenderer makes them too high-resolution. If on a device with pixel ratio 2, for instance, rendered SVGs will be 4 times as large in each dimension instead of 2, and on a device with pixel ratio 3, they will be 9 times as large instead of 3.
This causes jaggies from downscaling, reduces graphics performance, and wastes VRAM.