Old MIDI drum block support, featuring approximations via pitch shift #1613

towerofnix · 2018-09-26T00:27:18Z

Resolves

Fixes #1424. Sort of a follow up to #1329 and #355.

This also (not) accidentally allows the "set (audio) effect" block's "pitch" to have an effect on drums. I figure this is okay since the pan left/right effect already worked; and it's necessary to have the MIDI drum approximations.

Proposed Changes

Adds support for the obsolete drum:duration:elapsed:from: block, including very similar MIDI drum approximations to the ones originally created for Scratch 2.0.

Reason for Changes

Compatibility with old Scratch projects (and new ones which use that block).

Test Coverage

Tested manually by confirming that:

The examples in this project are all correct.
@as-com's "Canyon.mid" project runs correctly. (It's beautiful!)

This is probably done as is. There is data for decay, but there is no audio decay effect yet, so I don't think I can do anything with it yet.

src/extensions/scratch3_music/index.js

@@ -608,6 +608,62 @@ class Scratch3MusicBlocks {
        ];
    }

+    /**
+     * An array that is a mapping from MIDI drum numbers in range (35..81) to Scratch drum numbers.
+     * @type {Array[Array]} an array of information about the drums, in the format [drumNum, pitch, decay].


src/extensions/scratch3_music/index.js

+                    blockType: BlockType.COMMAND,
+                    text: formatMessage({
+                        id: 'music.midiPlayDrumForBeats',
+                        default: 'play drum [DRUM] for [BEATS] beats',


src/extensions/scratch3_music/index.js

+                    drumNum = midiDescription[0];
+                    pitchShift = midiDescription[1] * 10; // 10 = one semitone
+                } else {
+                    drumNum = 2;


src/extensions/scratch3_music/index.js

+        const pitchEffect = chain._effects.find(effect => effect.name === 'pitch')
+        if (pitchEffect) {
+            pitchEffect.updatePlayer(player);
+        }


ericrosenbaum · 2018-10-02T21:32:56Z

Thanks for this @towerofnix ! I'm excited to give this a look- due to other work it may have to wait a week or more.

…h-vm into towerofnix-midi-play-drum

ericrosenbaum · 2018-11-19T21:40:36Z

Okay this is working well, but I'd like to make some structural changes, and maybe remove the use of the pitch effect (for simplicity). If it's okay with you I will push some changes directly to the PR branch (assuming I can figure out how!).

update: I seem to have got into some git trouble. Looking into it..

This is probably done as is. There is data for decay, but there is no audio decay effect yet, so I don't think I can do anything with it yet.

…h-vm into midi-play-drum # Conflicts: # src/extensions/scratch3_music/index.js

towerofnix · 2018-11-20T00:03:35Z

@ericrosenbaum Okay! That's fine with me. Good luck fixing the git issues.. always a pain, of course :P

(In the uber-worst case scenario that this PR is utterly irredeemable, I have the commits separately on my computer - so it's easy to re-push/PR that if necessary.)

ericrosenbaum · 2018-11-20T18:41:02Z

@towerofnix Okay, @paulkaplan helped me fix the branch. Phew! But now that it has been force-pushed from my side, you won't be able to push correctly to it from your existing local branch. I can take over from here (just moving a few things around). If you do want to push any changes, I think you would just have to rename your local branch, then pull this one down, make the changes there, and push from it. Sorry again about the confusion (I learned something!).

towerofnix · 2018-11-20T22:15:47Z

@ericrosenbaum Alright, sounds good! And no problem! (:stars: ~The more you know~ :stars:)

Good to know - I've fixed up my own branch so it'll push/pull fine. I'm cool with you taking over from here. Just one thought:

I'd like to [..] maybe remove the use of the pitch effect (for simplicity).

I'm okay with this, but I think it is a pretty important part of simulating the sounds - several sounds just don't sound the same when their pitches aren't right. It's a lot of constant numbers which we can't be 100% sure are all exactly correct, but I think some effort will make them sound a lot better than none. There's not a lot of pressure to get them perfect either, since 1.4 MIDI-drum projects are relatively rare. Thoughts?

Aside - there are a few "decay" values which can be removed from that constants array, since I don't have any code for the feature and it would probably take a significant amount of effort to implement.

as-com · 2018-11-20T22:26:25Z

Aside - there are a few "decay" values which can be removed from that constants array, since I don't have any code for the feature and it would probably take a significant amount of effort to implement.

I think decay is very important; if it's not a ridiculous amount of effort to implement, it should be done (since some of my projects just don't sound right without the shorter decays of some instruments).

…h-vm into midi-play-drum

ericrosenbaum · 2018-11-28T19:52:50Z

Okay, I've now made the changes. The main thing is to keep the legacy Scratch 1.x-related code more separate from the rest of the code- so I just moved the drum number mapping into midiPlayDrumForBeats.

I recently fixed a couple of other bugs in the music extension by removing the use of the effects chain (#1735). This prevents us from using the pitch effect, so we will not be able to get the sound variations between the different 1.4 drums. I appreciate the clever work on this, but going forward we probably won't be able to use it.

Thanks for your help @towerofnix !

ericrosenbaum · 2018-11-28T20:41:46Z

Hm. In another hilarious github-related plot-twist, the diffs are not showing up correctly (apparently this is sometimes an issue on branches that have been force-pushed). I can't figure out a way to fix this PR, so I'm just going to create a new one.

ericrosenbaum · 2018-11-28T20:47:51Z

Replaced by #1790

MIDI drum support: approximations via pitch shift

f5aaf84

This is probably done as is. There is data for decay, but there is no audio decay effect yet, so I don't think I can do anything with it yet.

towerofnix commented Sep 26, 2018

View reviewed changes

Lint/jsdocs

5bb88ed

thisandagain added the pr - needs review label Oct 1, 2018

thisandagain assigned ericrosenbaum Oct 1, 2018

thisandagain added this to the October 2018 milestone Oct 1, 2018

Merge branch 'midi-play-drum' of https://github.com/towerofnix/scratc…

02b09cf

…h-vm into towerofnix-midi-play-drum

ericrosenbaum and others added 5 commits November 19, 2018 16:44

Hide legacy drum block from palette

982b2b6

MIDI drum support: approximations via pitch shift

fc8ebf5

This is probably done as is. There is data for decay, but there is no audio decay effect yet, so I don't think I can do anything with it yet.

Lint/jsdocs

413095d

Hide legacy drum block from palette

8561d09

Merge branch 'midi-play-drum' of https://github.com/towerofnix/scratc…

ea058a2

…h-vm into midi-play-drum # Conflicts: # src/extensions/scratch3_music/index.js

ericrosenbaum force-pushed the midi-play-drum branch from ea058a2 to 982b2b6 Compare November 20, 2018 18:10

ericrosenbaum added 2 commits November 27, 2018 17:59

Remove pitch shift for legacy drums

763cf45

Merge branch 'midi-play-drum' of https://github.com/towerofnix/scratc…

6c1741a

…h-vm into midi-play-drum

ericrosenbaum added pr - changes requested and removed pr - needs review labels Nov 27, 2018

ericrosenbaum modified the milestones: October 2018, November 2018 Nov 27, 2018

ericrosenbaum added 4 commits November 28, 2018 10:41

Fix drum playback

d895cf7

Keep legacy code isolated

eeee6f7

Comments

11035da

Fix JSDOC error

f7dd4e9

ericrosenbaum mentioned this pull request Nov 28, 2018

Add support for scratch 1.x MIDI drum blocks #1790

Merged

ericrosenbaum closed this Nov 28, 2018

towerofnix mentioned this pull request Jul 19, 2022

Support Music extension blocks leopard-js/leopard#135

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Old MIDI drum block support, featuring approximations via pitch shift #1613

Old MIDI drum block support, featuring approximations via pitch shift #1613

Uh oh!

towerofnix commented Sep 26, 2018

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

ericrosenbaum commented Oct 2, 2018

Uh oh!

ericrosenbaum commented Nov 19, 2018 •

edited

Loading

Uh oh!

towerofnix commented Nov 20, 2018

Uh oh!

ericrosenbaum commented Nov 20, 2018

Uh oh!

towerofnix commented Nov 20, 2018 •

edited

Loading

Uh oh!

as-com commented Nov 20, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

Uh oh!

Old MIDI drum block support, featuring approximations via pitch shift #1613

Old MIDI drum block support, featuring approximations via pitch shift #1613

Uh oh!

Conversation

towerofnix commented Sep 26, 2018

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

ericrosenbaum commented Oct 2, 2018

Uh oh!

ericrosenbaum commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

towerofnix commented Nov 20, 2018

Uh oh!

ericrosenbaum commented Nov 20, 2018

Uh oh!

towerofnix commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

as-com commented Nov 20, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

ericrosenbaum commented Nov 28, 2018

Uh oh!

Uh oh!

ericrosenbaum commented Nov 19, 2018 •

edited

Loading

towerofnix commented Nov 20, 2018 •

edited

Loading