Skip to content

Use new updateCPURenderAttributes in video sensing #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

Use new updateCPURenderAttributes in video sensing #2542

merged 1 commit into from
Aug 20, 2020

Conversation

apple502j
Copy link
Contributor

@apple502j apple502j commented Jul 31, 2020 •
edited
Loading

Resolves

Resolves #2541

Proposed Changes

Use new updateCPURenderAttributes in video sensing

Reason for Changes

Because @adroitwhiz forgot to change after merging scratchfoundation/scratch-render#664

Test Coverage

Updated test

adroitwhiz
adroitwhiz approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@adroitwhiz adroitwhiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someday we'll stop using these private APIs here....

@apple502j
Copy link
Contributor Author

@ericrosenbaum Can you merge this? There are many more BaG posts...
Per adroitwhiz's review this should be LGTM

@ericrosenbaum ericrosenbaum self-assigned this Aug 20, 2020
@ericrosenbaum
Copy link
Contributor

sorry for the delay on this @apple502j - working on it!

@adroitwhiz
Copy link
Contributor

To clarify -- scratchfoundation/scratch-render#555 was a refactor which didn't break video sensing. It added the updateCPURenderAttributes function, which called both updateMatrix and updateSilhouette.

Video sensing broke when scratchfoundation/scratch-render#664 was merged, which moved more logic into updateCPURenderAttributes, requiring it to be called before using isTouching.

@apple502j
Copy link
Contributor Author

@adroitwhiz okay thanks

ericrosenbaum
ericrosenbaum approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@ericrosenbaum ericrosenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericrosenbaum ericrosenbaum removed their assignment Aug 20, 2020
@ericrosenbaum ericrosenbaum merged commit c6962cb into scratchfoundation:develop Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrosenbaum ericrosenbaum ericrosenbaum approved these changes

@adroitwhiz adroitwhiz adroitwhiz approved these changes

Assignees
No one assigned
Labels
pr - good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video motion value for sprite is always zero until the sprite is interacted
3 participants
@apple502j @ericrosenbaum @adroitwhiz