Only uglify if building for production. #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uglify was trying to run always, including the dev-server output, which included es6 that broke uglifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uglify was trying to run always, including the dev-server output, which
included es6 that broke uglifier.
Resolves
What Github issue does this resolve (please include link)?
Fixes #774
Proposed Changes
Describe what this Pull Request does
Only uglify things when run in production environment.
Reason for Changes
Explain why these changes should be made
It was not possible to use the playground from a fresh install.
Test Coverage
Please show how you have added tests to cover your changes
Ran the npm run start from clean install, no errors.
The same problem exists on render, i'll update that repo with the same fix.