Skip to content

Update go.mod and imports so that we can build remotely #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jules opened this issue Dec 23, 2021 · 4 comments · Fixed by #15
Closed

Update go.mod and imports so that we can build remotely #14

jules opened this issue Dec 23, 2021 · 4 comments · Fixed by #15
Assignees
@jules

Comments

@jules
Copy link

jules commented Dec 23, 2021

No description provided.

@jules jules self-assigned this Dec 23, 2021
jules added a commit to jules/go-ethereum that referenced this issue Dec 23, 2021
@jules
Update mod file and all imports to use scroll-tech URL
6316b52 
Fixes scroll-tech#14
@jules jules mentioned this issue Dec 23, 2021
Merged
@mask-pp
Copy link

mask-pp commented Dec 23, 2021

We'd better not change, keep original is easier upgrade and maintenance.

@mask-pp mask-pp added invalid This doesn't seem right and removed invalid This doesn't seem right labels Dec 23, 2021
@jules
Copy link
Author

jules commented Dec 23, 2021

@mask-pp it's a fair point, and I will make sure we use the standard geth for any imports we need in the sequencer. However, building the repo will currently use the standard geth imports, so any of the changes we make to the scroll version will not reflect on build time. We also run into errors when trying to fetch the scroll version of geth on the sequencer repo, because the go.mod paths are mismatched. I'll update the issue title

@jules jules changed the title Update go.mod and imports so that we can use this repo as an import for the sequencer Update go.mod and imports so that we can build remotely Dec 23, 2021
@mask-pp mask-pp closed this as completed Dec 24, 2021
@mask-pp
Copy link

mask-pp commented Dec 24, 2021

@mask-pp it's a fair point, and I will make sure we use the standard geth for any imports we need in the sequencer. However, building the repo will currently use the standard geth imports, so any of the changes we make to the scroll version will not reflect on build time. We also run into errors when trying to fetch the scroll version of geth on the sequencer repo, because the go.mod paths are mismatched. I'll update the issue title

Yes, we neeed to do that change.

@jules jules reopened this Dec 24, 2021
@jules jules closed this as completed in #15 Dec 24, 2021
jules added a commit that referenced this issue Dec 24, 2021
@jules
Update mod file and all imports to use scroll-tech URL (#15)
de7ed6a 
* Update mod file and all imports to use scroll-tech URL

Fixes #14

* Update Discord link
0xmountaintop pushed a commit that referenced this issue Apr 20, 2023
@jules @0xmountaintop
Update mod file and all imports to use scroll-tech URL (#15)
4b30879 
* Update mod file and all imports to use scroll-tech URL

Fixes #14

* Update Discord link
@s7v7nislands
Copy link

@jules just curious, why not use replace command in go.mod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jules jules

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mod file and all imports to use scroll-tech URL jules/go-ethereum
3 participants
@s7v7nislands @jules @mask-pp