-
Notifications
You must be signed in to change notification settings - Fork 282
fix: print Euclid genesis config on startup #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update introduces two new timestamp fields into the configuration structure to track upgrade timings. The string representation method has been modified to output these new fields. Additionally, two new validation methods check whether a provided time meets or exceeds the upgrade thresholds for Euclid and Euclid V2. These changes enhance the configuration's ability to record and assess the blockchain upgrade timelines. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant ChainConfig
Caller->>ChainConfig: Call String()
ChainConfig-->>Caller: Return string with EuclidTime & EuclidV2Time
Caller->>ChainConfig: Call IsEuclid(now)
alt now >= EuclidTime
ChainConfig-->>Caller: true
else
ChainConfig-->>Caller: false
end
Caller->>ChainConfig: Call IsEuclidV2(now)
alt now >= EuclidV2Time
ChainConfig-->>Caller: true
else
ChainConfig-->>Caller: false
end
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (5)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
1. Purpose or design rationale of this PR
Add missing Euclid config logs.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?Summary by CodeRabbit