fix: address race condition during EuclidV2 header chain verification

[Thegaram]

1. Purpose or design rationale of this PR

A race condition during the verification of EuclidV2 transition headers occasionally lead to issues like this:

Verifying EuclidV2 transition header chain
Start EuclidV2 transition verification in Clique section startBlockNumber=14,906,951 endBlockNumber=14,907,014
Start EuclidV2 transition verification in SystemContract section startBlockNumber=14,907,015 endBlockNumber=14,907,910
Error verifying headers                  err="unknown ancestor"
Aborted EuclidV2 transition verification in SystemContract section
Invalid header encountered               number=14,907,015 hash=d0ba21..a048c6 parent=75c8df..83fe94 err="unknown ancestor"

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of header verification, reducing the chance of "unknown ancestor" errors during synchronization.
• Chores
  • Updated the patch version number.

[coderabbitai]

Error: Could not generate a valid Mermaid diagram after multiple attempts.

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b6f8f1 and ecbf7ab.

📒 Files selected for processing (2)

• consensus/wrapper/consensus.go (2 hunks)
• params/version.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

consensus/wrapper/consensus.go (2)

consensus/consensus.go (1)

• ChainHeaderReader (32-47)

core/types/block.go (1)

• Header (69-122)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test
• GitHub Check: Analyze (go)

🔇 Additional comments (3)

params/version.go (1)

27-27: Version bump looks appropriate for this bug fix.

The increment of VersionPatch from 45 to 46 follows standard semantic versioning practice for a non-breaking bug fix, which aligns with the race condition fix being implemented in the consensus wrapper.

consensus/wrapper/consensus.go (2)

62-85: Well-designed polling mechanism to replace fixed wait.

This new waitForHeader helper function effectively addresses the race condition by implementing a polling approach instead of a fixed sleep. The function tries to read the header every 2 seconds and gives up after 2 minutes with an appropriate warning log if the header is not found.

The timeout and polling interval choices are reasonable:

• 2-second polling is frequent enough to minimize delays
• 2-minute timeout provides sufficient time for normal operation while preventing indefinite hangs

---

152-155: Excellent fix for the race condition.

The implementation correctly addresses the race condition between VerifyHeader and InsertHeaderChain that was causing "unknown ancestor" errors. By waiting for the last clique header to be accessible before proceeding with system contract header verification, the code ensures proper synchronization between the two verification phases.

The comments clearly explain the nature of the race condition, making the solution easy to understand for future maintainers.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.