-
Notifications
You must be signed in to change notification settings - Fork 6
feat: enable js tracer #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #334 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've left some minor comments inline. Can you fix CI? We may need to remove the license type from the allow list to get deny working but I'm not sure. Do we also need to activet the js-tracer
feature in the rollup-node
repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There is a vulnerability has been detected. need to upgrade to |
We can do this in a future PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Because rundler must use
js-tracer
to validate the userOps.https://github.com/alchemyplatform/rundler/blob/main/crates/sim/src/simulation/v0_6/tracer.rs#L109
https://github.com/alchemyplatform/rundler/blob/main/crates/sim/src/simulation/v0_7/tracer.rs#L184
After investigation, found runder can use
--unsafe
to skip validation, butFlag for unsafe bundling mode. When set Rundler will skip checking simulation rules
.so it's better we can enable js-tracer