Skip to content

Conversation

georgehao
Copy link
Member

Because rundler must use js-tracer to validate the userOps.

https://github.com/alchemyplatform/rundler/blob/main/crates/sim/src/simulation/v0_6/tracer.rs#L109
https://github.com/alchemyplatform/rundler/blob/main/crates/sim/src/simulation/v0_7/tracer.rs#L184

After investigation, found runder can use --unsafe to skip validation, but Flag for unsafe bundling mode. When set Rundler will skip checking simulation rules.

so it's better we can enable js-tracer

@georgehao georgehao requested a review from frisitano September 4, 2025 08:00
@georgehao georgehao changed the title Feat/enable js tracer feat: enable js tracer Sep 4, 2025
Copy link

codspeed-hq bot commented Sep 4, 2025

CodSpeed Performance Report

Merging #334 will not alter performance

Comparing feat/enable_js_tracer (23c7472) with scroll (d485f47)

Summary

✅ 77 untouched benchmarks

@frisitano frisitano requested a review from yiweichi September 4, 2025 08:22
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've left some minor comments inline. Can you fix CI? We may need to remove the license type from the allow list to get deny working but I'm not sure. Do we also need to activet the js-tracer feature in the rollup-node repo?

yiweichi
yiweichi previously approved these changes Sep 4, 2025
Copy link
Member

@yiweichi yiweichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@georgehao
Copy link
Member Author

Looks good, I've left some minor comments inline. Can you fix CI? We may need to remove the license type from the allow list to get deny working but I'm not sure. Do we also need to activet the js-tracer feature in the rollup-node repo?

error[vulnerability]: Logging user input may result in poisoning logs with ANSI escape sequences
    ┌─ /Users/haohongfan-scroll/scroll/reth/Cargo.lock:915:1
    │
915 │ tracing-subscriber 0.3.19 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulner
ability detected

    │
    ├ ID: RUSTSEC-2025-0055
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0055
    ├ Previous versions of tracing-subscriber were vulnerable to ANSI escape sequence injection attac
ks. Untrusted user input containing ANSI escape sequences could be injected into terminal output when

There is a vulnerability has been detected. need to upgrade to tracing-subscriber 0.3.20

@frisitano
Copy link
Collaborator

There is a vulnerability has been detected. need to upgrade to tracing-subscriber 0.3.20

We can do this in a future PR

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@georgehao georgehao merged commit 260f87e into scroll Sep 5, 2025
44 checks passed
@georgehao georgehao deleted the feat/enable_js_tracer branch September 5, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants