-
Notifications
You must be signed in to change notification settings - Fork 3
feat: improve Docker e2e test framework and implement sequencer switching in the test #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…gner' into feat/claude.md
…e 500ms for both sequencers
…to connect to each other via RPC
This reverts commit 8bbc5e2.
…gner' into feat/improve-docker-e2e-test
…rom database in header transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements significant improvements to the Docker e2e test framework and introduces a comprehensive heterogeneous client synchronization test. The changes enhance the testing infrastructure's reliability and add validation for complex network scenarios involving multiple client implementations.
Key changes:
- Replaced a simple block propagation test with an extensive sequencer handoff test that validates cross-client synchronization
- Enhanced Docker testing framework with better timeout handling, container management, and peer networking utilities
- Consolidated workspace dependency management by centralizing reth dependencies in the root Cargo.toml
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/tests/heterogeneous_client_sync_and_sequencer_handoff.rs | New comprehensive test validating cross-client block propagation and sequencer transitions |
tests/tests/block_propagation_multi_clients.rs | Removed simple test replaced by the more comprehensive heterogeneous test |
tests/src/utils.rs | Added peer management functions and improved timeout handling for better test reliability |
tests/src/lib.rs | Simplified exports to use glob imports for better ergonomics |
tests/src/docker_compose.rs | Enhanced container management with IP resolution, enode URL construction, and log dumping |
tests/launch_*.bash | Updated node configuration scripts to enable admin APIs and improve networking |
tests/l2geth-genesis-e2e.json | Added blocks_per_second configuration for system contract |
Cargo.toml files | Consolidated reth dependencies to use workspace-level definitions |
Dockerfile.test | Added sccache for faster builds and improved cache mounting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a few commens inline.
Closes #274