Skip to content

Additional pages and update of elements for friday review. a few article need f/u #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 30, 2023
Merged

Additional pages and update of elements for friday review. a few article need f/u #9

merged 12 commits into from
May 30, 2023

Conversation

dghelm
Copy link
Contributor

@dghelm dghelm commented Apr 14, 2023

No description provided.

@dghelm dghelm requested a review from andyrdt April 14, 2023 03:34
@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 4406049
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/64750185a51f790008d2b9d2
😎 Deploy Preview https://deploy-preview-9--scroll-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dghelm
Copy link
Contributor Author

dghelm commented May 29, 2023

A few notes:

  • image folders updated to "_images" to avoid being indexed as content (resolving console warnings)
  • URL scheme slightly changes, and we'll need to revisit zh translation tokens once we get the full scaffold finished for the English articles.

@dghelm dghelm requested review from OrestTa and zzq0826 May 29, 2023 19:50
zzq0826
zzq0826 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@zzq0826 zzq0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzq0826 zzq0826 merged commit 1ea7d62 into develop May 30, 2023
@dghelm dghelm deleted the new-content branch May 30, 2023 23:39
yeguclu pushed a commit to yeguclu/scroll-documentation that referenced this pull request Apr 6, 2024
@Turupawn
Merge pull request scroll-tech#9 from emremreistaken/develop
6429579 
Tr translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzq0826 zzq0826 zzq0826 approved these changes

@andyrdt andyrdt Awaiting requested review from andyrdt

@OrestTa OrestTa Awaiting requested review from OrestTa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dghelm @zzq0826 @andyrdt @OrestTa