feat: euclid v1 GPU prover #1608
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update modifies the dependency configuration for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## omerfirmak/euclid-prover #1608 +/- ##
============================================================
- Coverage 42.15% 42.13% -0.02%
============================================================
Files 222 222
Lines 17733 17732 -1
============================================================
- Hits 7475 7472 -3
- Misses 9550 9551 +1
- Partials 708 709 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kunxian-xia
changed the base branch from
omerfirmak/euclid-prover
to
euclid-prover/update-zkvm-circuit-to-0.1.0-rc.6
kunxian-xia
force-pushed
the
kunxian/euclid-gpu-prover
branch
from
5919aa2 to
327a1d8
Compare
|
The zkvm gpu prover is built by https://github.com/scroll-tech/devops/pull/548. |
|
|
kunxian-xia
force-pushed
the
kunxian/euclid-gpu-prover
branch
from
ef7310d to
2abbbbd
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
zkvm-prover/Cargo.toml (2)
48-50: Review: Stark Backend GPU Patch ConfigurationThe new patch section correctly routes both
openvm-stark-backendandopenvm-stark-sdkto the GPU-enabled fork (openvm-stark-gpu.git) on themainbranch with thegpufeature enabled. Please verify that using SSH URLs is acceptable in your build environment (e.g., ensuring all CI/CD agents and developers have proper SSH key access), or consider using HTTPS URLs if broader accessibility is needed.
52-77: Review: Plonky3 GPU Patch DependenciesThis section comprehensively replaces the original Plonky3 dependencies with their GPU-enabled counterparts from
plonky3-gpu.giton theopenvm-v2branch. The inline comment forp3-maybe-rayonclarifies that the "parallel" feature is not enabled by default, which is helpful. A few suggestions to consider:
- Reproducible Builds: Since all dependencies are pointed to a branch, consider pinning them to a specific commit or tag to ensure reproducibility and avoid potential breaking changes if the branch is updated.
- SSH URL Usage: As with the Stark backend patch, ensure that the SSH URLs do not hinder integration in environments that might not have SSH key configurations set up.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
zkvm-prover/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
zkvm-prover/Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: tests
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
coordinator/internal/logic/auth/login.go (1)
45-47: Special handling for "euclid" hard fork should be documentedThis change introduces special case logic for the "euclid" hard fork, preventing the low version circuit's fork name from being included in the high version's hard forks list specifically for this fork. While the implementation is correct, the rationale behind this special handling is not explained in comments, which could make maintenance more difficult for future developers.
Consider adding a comment explaining why the "euclid" fork requires this special treatment:
+ // When using the "euclid" hard fork, we only include the high version circuit's fork name + // because euclid is specifically designed for GPU acceleration and doesn't need backward compatibility + // with the low version circuit fork if cfg.ProverManager.Verifier.HighVersionCircuit.ForkName != "euclid" { highHardForks = append(highHardForks, cfg.ProverManager.Verifier.LowVersionCircuit.ForkName) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
zkvm-prover/Cargo.lockis excluded by!**/*.lockcommon/libzkp/impl/Cargo.lockis excluded by!**/*.lockzkvm-prover/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
common/version/version.go(1 hunks)common/version/version.go(1 hunks)coordinator/internal/logic/auth/login.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: tests
🔇 Additional comments (2)
common/version/version.go (1)
8-8: Version bumped to v4.4.93 for GPU prover feature.This is an appropriate version increment to reflect the addition of GPU prover functionality being introduced in this PR.
coordinator/internal/logic/auth/login.go (1)
45-47: Verify integration with GPU prover functionalityThis conditional handling of the "euclid" hard fork is likely related to the GPU prover enablement mentioned in the PR objectives. The change ensures that when using the "euclid" fork, only that fork is mapped to the high version prover, which suggests "euclid" may be a GPU-specific fork.
Can you confirm that this change is indeed necessary for the GPU prover to function correctly? Also, are there any specific test cases that validate this behavior to ensure it doesn't break existing functionality?
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 3
🧹 Nitpick comments (19)
database/migrate/migrations/00025_add_l1_message_queue_hash.sql (1)
4-10: Consider adding VARCHAR size constraints for hash fields.The migration successfully adds message queue hash columns to both tables. However, for hash values, it's best practice to specify the VARCHAR size (e.g., VARCHAR(66) for Ethereum hashes) rather than using unbounded VARCHAR.
ALTER TABLE chunk -ADD COLUMN prev_l1_message_queue_hash VARCHAR DEFAULT '', -ADD COLUMN post_l1_message_queue_hash VARCHAR DEFAULT ''; +ADD COLUMN prev_l1_message_queue_hash VARCHAR(66) DEFAULT '', +ADD COLUMN post_l1_message_queue_hash VARCHAR(66) DEFAULT ''; ALTER TABLE batch -ADD COLUMN prev_l1_message_queue_hash VARCHAR DEFAULT '', -ADD COLUMN post_l1_message_queue_hash VARCHAR DEFAULT ''; +ADD COLUMN prev_l1_message_queue_hash VARCHAR(66) DEFAULT '', +ADD COLUMN post_l1_message_queue_hash VARCHAR(66) DEFAULT '';rollup/internal/config/relayer.go (1)
34-41: Consider adding boundary checks and using a duration-type field.
While definingTimeoutSecas anint64is fine, it might be more idiomatic to represent time intervals usingtime.Durationin Go to avoid unit confusion. Similarly, you may want to ensure thatMinBatchesandMaxBatchesare validated (e.g., disallow negatives) to avoid unpredictable behavior.bridge-history-api/cmd/fetcher/app/app.go (1)
71-74: Consider whether a graceful fail is needed instead oflog.Crit.
Currently, ifNewL1MessageFetcherfails, the code useslog.Crit, causing an immediate process exit. This may be correct if continued runtime is impossible without the fetcher. Otherwise, consider a softer shutdown if partial functionality is acceptable.bridge-history-api/internal/controller/fetcher/l1_fetcher.go (2)
42-49: Consider surfacing BeaconNode creation error at the caller level.
This code logs a warning on error but continues execution, potentially leading to a partially configured blob client. If the caller expects full blob client availability, you might want to fail fast.- log.Warn("failed to create BeaconNodeClient", "err", err) + return nil, fmt.Errorf("failed to create BeaconNodeClient: %w", err)
50-55: Check for errors in additional blob client setups.
Similar to the BeaconNode logic, errors during creation are not surfaced. This can be acceptable if partial configurations are allowed, but it may also hide important failures.rollup/tests/rollup_test.go (2)
131-132: Use of require.Eventually for asynchronous checks is valid.
Be aware of potential test flakiness if the underlying operations take longer than expected or vary in timing.
221-349: New test "testCommitBatchAndFinalizeBundleCodecV7" is comprehensive but quite large.
- Considers multiple blocks, commits, and validations.
- Uses repeated "fmt.Println" calls; consider switching to structured logging or testing logs for clarity.
- Potentially break it into smaller sub-tests if it becomes unwieldy.
- fmt.Println("block number: ") + t.Logf("block number: %v", ...)rollup/abi/bridge_abi_test.go (1)
175-190: Added utility to print ABI signaturesWhile this appears to be more of a development utility than a test, it's useful for debugging and understanding the ABI structure. Consider adding a flag to skip this in normal test runs or moving it to a separate utility package.
-func TestPrintABISignatures(t *testing.T) { +func TestPrintABISignatures(t *testing.T) { + if testing.Short() { + t.Skip("skipping test in short mode") + } // print all error signatures of ABI abi, err := ScrollChainMetaData.GetAbi() if err != nil { t.Fatal(err) }bridge-history-api/internal/logic/l1_event_parser.go (6)
31-37: Improve constructor documentation.
The constructor now accepts and sets ablobClient. Consider documenting howblobClientis used, especially around retrieving, parsing, or verifying blob data. Clear comments improve code readability and maintainability.
240-254: Refine multi-event approach description.
The inline comments explaining multi-event logic for version ≥ 7 are helpful but somewhat verbose. Consider refactoring them into smaller code comments or docstrings, which may be easier to maintain and read.
283-287: Validate blobHashes array length more robustly.
This block checks ifcurrentIndexexceeds the array length, returning an error. Consider also logging the transaction details or referencing the batch index for better debugging context.
304-306: Ensure mismatch logs are consistent.
When there's a mismatch betweenevent.BatchHashandcalculatedBatch.Hash(), add the transaction hash or block number to the logs to help pinpoint the cause in real scenarios.
343-355: Evaluate revert range for correctness & consistency.
The iteration fromevent.StartBatchIndextoevent.FinishBatchIndexuses a<=operator. Confirm this behavior is correct for your revert logic (inclusive range). Off-by-one mistakes here could lead to partial reverts or skipping the last batch.
472-495: Handle larger payloads in blob retrieval gracefully.
The functiongetBatchBlockRangeFromBlobdecodes the blob payload. If future expansions hold significantly larger data, ensure that decode times and memory usage won't degrade performance excessively.rollup/internal/controller/relayer/l2_relayer.go (5)
407-412: Log multiple version mismatches more readably.
If the batch's codec version differs from the chunk's version, the log includes multiple fields. Consider adding more context (e.g., batch hash, chunk hash) to help isolate issues.
416-417: Clarify error message for index zero.
"Should only happen in committing genesis batch" might confuse future developers. If this actually never occurs outside genesis, consider panicking or clarifying if there's a fallback path.
421-429: Account for missing parent batch.
In the first iteration (i==0), retrieving the parent batch by indexdbBatch.Index-1might fail if existing data is out of sync or partially purged. Handle or log this scenario more gracefully.
473-475: Extract forced submission logic into a helper function.
TheforceSubmitlogic surfaces in multiple places. Factor it out so it's easy to maintain if the approach to timeouts or forced submissions evolves.
499-521: Improve error context in commit batch failure.
WhenSendTransactionfails, logs could capture the batch indices in a single line, along with parent batch details. This ensures we can trace the entire batch set.
🛑 Comments failed to post (3)
bridge-history-api/internal/logic/l1_event_parser.go (1)
25-28: 💡 Verification agent
🧩 Analysis chain
Add defensive checks for nil pointers.
When creating a newL1EventParserinstance, consider validating thatcfg,client, andblobClientare not nil before assigning them. This helps prevent nil-pointer dereferences in downstream methods.You can verify that all callers provide non-nil arguments by searching for their usage:
🏁 Script executed:
#!/bin/bash ast-grep --pattern $'NewL1EventParser($_, $_, $_)'Length of output: 165
Defensive nil-check required in NewL1EventParser
It appears that the constructor for
L1EventParsercurrently assigns the provided pointers without checking if any are nil. Our ast-grep search confirmed a single invocation inbridge-history-api/internal/logic/l1_fetcher.go:137, but even if callers currently pass non-nil arguments, nothing prevents future regressions or inadvertent nil values. I recommend updating theNewL1EventParserconstructor (inbridge-history-api/internal/logic/l1_event_parser.go) to explicitly verify thatcfg,client, andblobClientare not nil—returning an error or panicking as appropriate—to ensure safety in downstream usage.
- Action Items:
- Update
NewL1EventParserto include checks like:if cfg == nil { return nil, errors.New("config cannot be nil") } if client == nil { return nil, errors.New("ethereum client cannot be nil") } if blobClient == nil { return nil, errors.New("blob client cannot be nil") }- Consider adding unit tests that pass nil for each parameter to ensure the constructor handles these scenarios gracefully.
rollup/internal/controller/relayer/l2_relayer.go (1)
986-997: 🛠️ Refactor suggestion
Handle multiple batch hashes properly during confirmations.
When updating each batch's status in a loop, ensure no partial updates if an error occurs halfway. A dedicated function that can roll back changes on partial updates might be beneficial.rollup/abi/bridge_abi.go (1)
27-28: 🛠️ Refactor suggestion
Validate function overloading and event duplication.
The updated ABI includes overloadedrevertBatchfunctions and multipleRevertBatchevents. Confirm that consumer code can distinguish them correctly, especially in typed languages or tools.-{"type":"function","name":"revertBatch","inputs":[{"name":"batchHeader","type":"bytes","internalType":"bytes"},{"name":"count","type":"uint256"}]} +{"type":"function","name":"revertBatchV0","inputs":[{"name":"batchHeader","type":"bytes","internalType":"bytes"},{"name":"count","type":"uint256"}]}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.ABI: "[{\"type\":\"function\",\"name\":\"commitAndFinalizeBatch\",\"inputs\":[{\"name\":\"version\",\"type\":\"uint8\",\"internalType\":\"uint8\"},{\"name\":\"parentBatchHash\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"finalizeStruct\",\"type\":\"tuple\",\"internalType\":\"struct ScrollChainInterface.FinalizeStruct\",\"components\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"totalL1MessagesPoppedOverall\",\"type\":\"uint256\",\"internalType\":\"uint256\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"zkProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}]}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"commitBatch\",\"inputs\":[{\"name\":\"version\",\"type\":\"uint8\",\"internalType\":\"uint8\"},{\"name\":\"parentBatchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"chunks\",\"type\":\"bytes[]\",\"internalType\":\"bytes[]\"},{\"name\":\"skippedL1MessageBitmap\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"commitBatchWithBlobProof\",\"inputs\":[{\"name\":\"version\",\"type\":\"uint8\",\"internalType\":\"uint8\"},{\"name\":\"parentBatchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"chunks\",\"type\":\"bytes[]\",\"internalType\":\"bytes[]\"},{\"name\":\"skippedL1MessageBitmap\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"blobDataProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"commitBatches\",\"inputs\":[{\"name\":\"version\",\"type\":\"uint8\",\"internalType\":\"uint8\"},{\"name\":\"parentBatchHash\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"lastBatchHash\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBatch\",\"inputs\":[{\"name\":\"_batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"_prevStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"_postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"_withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBatch4844\",\"inputs\":[{\"name\":\"_batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"_postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"_withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"_blobDataProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBatchWithProof\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"prevStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"aggrProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBatchWithProof4844\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"prevStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"blobDataProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"aggrProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBundle\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBundlePostEuclidV2\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"totalL1MessagesPoppedOverall\",\"type\":\"uint256\",\"internalType\":\"uint256\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"aggrProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBundlePostEuclidV2NoProof\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"totalL1MessagesPoppedOverall\",\"type\":\"uint256\",\"internalType\":\"uint256\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeBundleWithProof\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"},{\"name\":\"aggrProof\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"finalizeEuclidInitialBatch\",\"inputs\":[{\"name\":\"postStateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"importGenesisBatch\",\"inputs\":[{\"name\":\"_batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"_stateRoot\",\"type\":\"bytes32\",\"internalType\":\"bytes32\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"revertBatchV0\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"},{\"name\":\"count\",\"type\":\"uint256\",\"internalType\":\"uint256\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"function\",\"name\":\"revertBatch\",\"inputs\":[{\"name\":\"batchHeader\",\"type\":\"bytes\",\"internalType\":\"bytes\"}],\"outputs\":[],\"stateMutability\":\"nonpayable\"},{\"type\":\"event\",\"name\":\"CommitBatch\",\"inputs\":[{\"name\":\"batchIndex\",\"type\":\"uint256\",\"indexed\":true,\"internalType\":\"uint256\"},{\"name\":\"batchHash\",\"type\":\"bytes32\",\"indexed\":true,\"internalType\":\"bytes32\"}],\"anonymous\":false},{\"type\":\"event\",\"name\":\"FinalizeBatch\",\"inputs\":[{\"name\":\"batchIndex\",\"type\":\"uint256\",\"indexed\":true,\"internalType\":\"uint256\"},{\"name\":\"batchHash\",\"type\":\"bytes32\",\"indexed\":true,\"internalType\":\"bytes32\"},{\"name\":\"stateRoot\",\"type\":\"bytes32\",\"indexed\":false,\"internalType\":\"bytes32\"},{\"name\":\"withdrawRoot\",\"type\":\"bytes32\",\"indexed\":false,\"internalType\":\"bytes32\"}],\"anonymous\":false},{\"type\":\"event\",\"name\":\"RevertBatch\",\"inputs\":[{\"name\":\"batchIndex\",\"type\":\"uint256\",\"indexed\":true,\"internalType\":\"uint256\"},{\"name\":\"batchHash\",\"type\":\"bytes32\",\"indexed\":true,\"internalType\":\"bytes32\"}],\"anonymous\":false},{\"type\":\"event\",\"name\":\"RevertBatch\",\"inputs\":[{\"name\":\"startBatchIndex\",\"type\":\"uint256\",\"indexed\":true,\"internalType\":\"uint256\"},{\"name\":\"finishBatchIndex\",\"type\":\"uint256\",\"indexed\":true,\"internalType\":\"uint256\"}],\"anonymous\":false},{\"type\":\"event\",\"name\":\"UpdateEnforcedBatchMode\",\"inputs\":[{\"name\":\"enabled\",\"type\":\"bool\",\"indexed\":false,\"internalType\":\"bool\"},{\"name\":\"lastCommittedBatchIndex\",\"type\":\"uint256\",\"indexed\":false,\"internalType\":\"uint256\"}],\"anonymous\":false}]"
kunxian-xia
changed the title
colinlyguo
changed the title
…ian/euclid-gpu-prover
|
Both |
Overview
Patches
We patch the following crates
Summary by CodeRabbit