-
Notifications
You must be signed in to change notification settings - Fork 621
fix(bridge-history): overwrite l2geth dependency by replace #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-history): overwrite l2geth dependency by replace #1617
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change updates the dependency management in the Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bridge-history-api/go.mod (1)
20-21
: Clarify the Replace Directive
Thereplace
directive explicitly overridesgithub.com/scroll-tech/go-ethereum
to the same version, which reinforces the hotfix context for header hash incompatibility. Consider revising the comment to adopt a more formal tone (for example, "Hotfix: header hash incompatibility; update with caution") to improve clarity and future maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bridge-history-api/go.mod
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: rollup-db-cli
- GitHub Check: rollup_relayer
- GitHub Check: gas_oracle
- GitHub Check: coordinator-cron
- GitHub Check: coordinator-api
- GitHub Check: bridgehistoryapi-db-cli
- GitHub Check: bridgehistoryapi-api
- GitHub Check: bridgehistoryapi-fetcher
- GitHub Check: check
- GitHub Check: test
- GitHub Check: tests
🔇 Additional comments (1)
bridge-history-api/go.mod (1)
13-13
: Confirm Dependency Version Consistency
The dependency version forgithub.com/scroll-tech/go-ethereum
is now explicitly set tov1.10.14-0.20250305084331-57148478e950
in therequire
block. Please confirm that this version is intentional and consistent with project requirements.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1617 +/- ##
========================================
Coverage 42.11% 42.11%
========================================
Files 222 222
Lines 17741 17741
========================================
Hits 7471 7471
Misses 9560 9560
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b6548f7
to
035f7b1
Compare
Purpose or design rationale of this PR
This PR overwrites l2geth dependency by
replace
, the dependency is a hotfix commit.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?Summary by CodeRabbit
Chores
Version Update