-
Notifications
You must be signed in to change notification settings - Fork 626
fix(coordinator): reset roller state when proof session timeout #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scroll-dev
merged 14 commits into
staging
from
fix/reset-roller-state-when-session-timeout
Jan 19, 2023
Merged
fix(coordinator): reset roller state when proof session timeout #210
scroll-dev
merged 14 commits into
staging
from
fix/reset-roller-state-when-session-timeout
Jan 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let also bump the version number |
Thegaram
previously approved these changes
Jan 9, 2023
The reset may cause the coordinator to assign tasks to slow provers, thus the tasks assigned to these slow provers may be delayed. |
TODO: this is a temporary fix, will replace |
534591d
to
372a1fd
Compare
4780a4d
to
dbb841a
Compare
0xmountaintop
previously approved these changes
Jan 19, 2023
mask-pp
previously approved these changes
Jan 19, 2023
938bafa
0xmountaintop
previously approved these changes
Jan 19, 2023
Thegaram
approved these changes
Jan 19, 2023
0xmountaintop
approved these changes
Jan 19, 2023
scroll-dev
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Symptom:
Analysis:
In the above scenario, the coordinator does not run
freeTaskIDForRoller
since the roller discards the task itself and never submits the proof. Then the coordinator would always treat the roller asnot idle
(won't assign a new task to the roller).Fix:
Run
freeTaskIDForRoller
when proof session timeouts.Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has
tag
incommon/version.go
been updated?Yes, and updated.
Is this PR a breaking change? If so, have it been attached a
breaking-change
label?No