Skip to content

Conversation

Lawliet-Chan
Copy link
Contributor

@Lawliet-Chan Lawliet-Chan commented Feb 9, 2023

  1. Purpose or design rationale of this PR
    Dump the zk proof. Should merge after feat(roller&coordinator): upgrade lizkp to zkevm-0215 version #281

  2. Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
    no

  3. Is this PR a breaking change? If so, have it been attached a breaking-change label?
    No

@ChuhanJin
Copy link
Contributor

46% (-0.16%) vs master 47%

@Lawliet-Chan
Copy link
Contributor Author

Should we store the complete proof in coordinator?

@ChuhanJin
Copy link
Contributor

47% (0.0%) vs master 47%

@ChuhanJin
Copy link
Contributor

47% (0.0%) vs master 47%

@ChuhanJin
Copy link
Contributor

46% (0.0%) vs master 46%

@Lawliet-Chan Lawliet-Chan changed the title add dump proof feat(roller): add dump proof Feb 14, 2023
@ChuhanJin
Copy link
Contributor

46% (0.0%) vs master 46%

@Lawliet-Chan Lawliet-Chan marked this pull request as ready for review February 20, 2023 07:33
@Lawliet-Chan Lawliet-Chan marked this pull request as draft February 20, 2023 07:39
@ChuhanJin
Copy link
Contributor

46% (0.0%) vs master 46%

@Lawliet-Chan Lawliet-Chan requested review from 0xmountaintop and colinlyguo and removed request for 0xmountaintop March 21, 2023 01:37
@Lawliet-Chan Lawliet-Chan marked this pull request as ready for review March 21, 2023 02:12
colinlyguo
colinlyguo previously approved these changes Mar 21, 2023
Copy link
Contributor

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xmountaintop
Copy link
Contributor

bump version

@ChuhanJin
Copy link
Contributor

43% (-2.28%) vs master 45%

@0xmountaintop 0xmountaintop merged commit ceb406b into develop Mar 22, 2023
@0xmountaintop 0xmountaintop deleted the dump_proof branch March 22, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants