Skip to content

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Feb 28, 2023

  1. Purpose or design rationale of this PR
    Let MaxOpenConns and MaxIdleConns available.

  2. Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
    Yes.

  3. Is this PR a breaking change? If so, have it been attached a breaking-change label?
    No.

@ChuhanJin
Copy link
Contributor

44% (-1.96%) vs master 46%

@ChuhanJin
Copy link
Contributor

44% (-1.96%) vs master 46%

Copy link
Contributor

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmountaintop
Copy link
Contributor

replaced with #328

@0xmountaintop 0xmountaintop deleted the maskpp/sqlx_delay branch February 28, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants