Move adding --internet-tests option back to conftest.py
#685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs to be where `pytest` gets called from, otherwise it doesn't work.
|
Yes, sorry, I wasn’t aware of this. Please add a small comment explaining this. |
|
Added. Do you think we should keep multiple |
|
multiple are fine, I like having the test setup in the tests directory |
awnimo
pushed a commit
to dpeerlab/scanpy
that referenced
this pull request
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest_addoptionandpytest_collection_modifyitemshave to be defined wherepytestgets called from, otherwise they don't work.@flying-sheep, I saw you had changed this in d979267. Was there a functional reason you moved these things, or was it aesthetic?