-
Notifications
You must be signed in to change notification settings - Fork 71
Zarr v3 support #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr v3 support #969
Conversation
Thanks for opening this PR, Luca! 😄 |
Things that changed (listing also the open todos as tick items). ~250 tests were failing. Now we are down to ~120 failing.
|
Currently blocked by ome/ome-zarr-py#477 |
|
In the latest commit I started (still wip) removing the usage of Importantly, In particular, when calling
We should not solve this with ad-hoc checks, but by using the right API from |
|
@falexwolf @Zethson @BioinfoTongLI Everything done now, just ome/ome-zarr-py#491 is blocking at the moment. |
@melonora reviewing the latest commit. First one comment:
|
I fixed it. That function can indeed be removed. I also sorted the fixtures in the 2 last |
Code review finished! Great work @melonora. The only piece missing is ome/ome-zarr-py#491, after this we can merge! |
@LucaMarconato don't merge this yet, fixing an issue |
I noticed that we were creating a new Furthermore, I have added the functionality of checking with which format the data is written so we can request the correct reader from |
* refactor read_zarr * remove unneccesary checks
will reopen the PR as we can't change PR author. |
closes #979
Resources: